1753830 - [LINUX] The scrollbar thumb is near invisible and has a horribly low contrast

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Artem S. Tashkinov]

Attachment: scrollbar.png

Steps to reproduce:

The scrollbar thumb is near invisible and has a horribly low contrast.

I have quite a wide 10bit monitor with an excellent color reproduction and at an angle the thumb simply disappears.

I'm using Firefox 96 from https://ftp.mozilla.org/pub/firefox/releases/ with XFCE 4 under Fedora 35 using the Graybird GTK theme.

The theme has no effect on Firefox's appearance whatsoever.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753830 - Add a pref to allow disabling themed scrollbar colors. r=stransky

This is useful for testing.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753830 - Take GTK unthemed scrollbar colors from Adwaita. r=stransky

Rather than windows 10, which has much wider scrollbars.

Depends on D137937

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753830 - Allow using dark themed scrollbars on GTK too. r=stransky

This is faster and more straight-forward code than the old
ShouldUseDarkScrollbar shenanigans, and allows to have dark-themed
scrollbars.

Depends on D137938

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753830 - Move a bunch of cocoa-specific scrollbar code to ScrollbarDrawingCocoa.cpp. r=spohl,mstange

Drive-by but we can do this now that this code is not needed by
nsNativeThemeCocoa (bug 1749531).

Depends on D138077

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae0553a7ef8d
Add a pref to allow disabling themed scrollbar colors. r=stransky
https://hg.mozilla.org/integration/autoland/rev/a55efaf05779
Take GTK unthemed scrollbar colors from Adwaita. r=stransky

Comment 7

[Phabricator Automation]

Comment on attachment 9262752 [details]
Bug 1753830 - Allow using dark themed scrollbars on GTK too. r=stransky

Revision D138077 was moved to bug 1754225. Setting attachment 9262752 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9262758 [details]
Bug 1753830 - Move a bunch of cocoa-specific scrollbar code to ScrollbarDrawingCocoa.cpp. r=spohl,mstange

Revision D138083 was moved to bug 1754225. Setting attachment 9262758 [details] to obsolete.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753830 - Some more trivial clean-ups to the cocoa scrollbar drawing code. r=spohl,mstange

Use LayoutDeviceRect consistently, and add default initializers.

Depends on D138083

Comment 10

[Phabricator Automation]

Comment on attachment 9262758 [details]
Bug 1753830 - Move a bunch of cocoa-specific scrollbar code to ScrollbarDrawingCocoa.cpp. r=spohl,mstange

Revision D138083 was moved to bug 1754225. Setting attachment 9262758 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9262865 [details]
Bug 1753830 - Some more trivial clean-ups to the cocoa scrollbar drawing code. r=spohl,mstange

Revision D138164 was moved to bug 1754225. Setting attachment 9262865 [details] to obsolete.

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ae0553a7ef8d
https://hg.mozilla.org/mozilla-central/rev/a55efaf05779